[libcxx-commits] [PATCH] D101085: [libc++][doc] Adds a Format library status page.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added subscribers: vitaut, Quuxplusone.
Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

"Ship it!" SGTM. Feel free to hold off if you're looking for review specifically from Louis (or @vitaut) or something.



================
Comment at: libcxx/docs/FormatIssuePaperStatus.csv:8
+`LWG-3242 <https://wg21.link/LWG3242>`_,"std::format: missing rules for arg-id in width  and precision",,,,
+`LWG-3243 <https://wg21.link/LWG3243>`_,"std:;format and negative zeroes",,,,
+`LWG-3246 <https://wg21.link/LWG3246>`_,"What are the constraints on the template parameter of basic_format_arg?",,,,
----------------
`/:;/::/`
Also grep for two-spaces-in-a-row.


================
Comment at: libcxx/docs/FormatProposalStatus.csv:2
+Section,Description,Dependencies,Assignee,Patch,Status,First released version
+[charconv.to.chars],Fix integral conformance,,Mark de Wever,`D97705 <https://llvm.org/D97705>`__,WIP,
+[charconv.to.chars],Add floating-point conversion,`D97705 <https://llvm.org/D97705>`__,"Mark de Wever (Code provided by Stephan T. Lavavej of Microsoft)",`D70631 <https://llvm.org/D70631>`__,WIP,
----------------
zoecarver wrote:
> Nit: we say "In Progress" in the other status documents, so might make sense to say that instead of WIP here. That being said, people will get the idea, so I don't think it matters too much. You could fix this locally, leave it, or fix it later. 
It'd also be nice to put `"` quotes around //all// the paper titles, not just the ones with embedded commas. Will reduce cut-and-paste errors in the future.


================
Comment at: libcxx/docs/FormatStatus.rst:39-40
+
+(Note: files with required updates will contain TODO FMT comments with the
+parts not implemented.)
+
----------------
FWIW, I don't understand what qualifies as a "required update" in this context. Is that like a Windows security patch? ;)
I suspect this sentence just means "Please mark all Format-related TODO comments with the string `TODO FMT`, so we can find them easily."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101085/new/

https://reviews.llvm.org/D101085