[libcxx-commits] [PATCH] D100073: [libcxx][iterator] adds `std::indirectly_readable` and `std::indirectly_writable`

Mikael Holmén via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 22 01:24:23 PDT 2021


uabelho added a comment.

Hi,

With this patch I get errors in all the new testcases. I get

  error: no member named 'indirectly_readable' in namespace 'std'

and

  error: no member named 'indirectly_writable' in namespace 'std'

I noticed that if I explicitly add

  #include <__iterator/concepts.h>

it seems to find indirectly_readable and indirectly_writable and the testcase I tried in passed.
I've looked at iterator and see it includes <concepts>, but I can't find anyone actually including <__iterator/concepts.h>?

How is this supposed to work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100073/new/

https://reviews.llvm.org/D100073



More information about the libcxx-commits mailing list