[libcxx-commits] [PATCH] D100587: [libc++][ranges] iterator.concept.sizedsentinel: sized_sentinel_for and disable_sized_sentinel_for.

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Apr 21 21:58:07 PDT 2021


cjdb added a comment.

`std::list` still hasn't had its conformance test updated.



================
Comment at: libcxx/test/std/containers/sequences/deque/iterator_concept_conformance.compile.pass.cpp:53-61
+static_assert(!std::sized_sentinel_for<reverse_iterator, iterator>);
+static_assert(!std::sized_sentinel_for<reverse_iterator, const_iterator>);
+static_assert(std::sized_sentinel_for<reverse_iterator, reverse_iterator>);
+static_assert(std::sized_sentinel_for<reverse_iterator, const_reverse_iterator>);
+
+static_assert(!std::sized_sentinel_for<const_reverse_iterator, iterator>);
+static_assert(!std::sized_sentinel_for<const_reverse_iterator, const_iterator>);
----------------
Thos lot isn't necessary (`std::reverse_iterator` gets its own file so it doesn't need to be on the LHS, but it looks to me like that file is missing?).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100587/new/

https://reviews.llvm.org/D100587



More information about the libcxx-commits mailing list