[libcxx-commits] [PATCH] D100866: Add a buildkite for _LIBCPP_DEBUG=1.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

This is indeed quite nice! Some comments, but I love that we're adding this.



================
Comment at: libcxx/cmake/caches/Generic-debug.cmake:1
+set(LIBCXX_TEST_PARAMS "std=c++2b" "debug_level=1" "additional_features=LIBCXX-DEBUG-FIXME" CACHE STRING "")
+set(LIBCXXABI_TEST_PARAMS "${LIBCXX_TEST_PARAMS}" CACHE STRING "")
----------------
This shouldn't set `std=c++2b` explicitly, I believe we should be using the default here.


================
Comment at: libcxx/utils/ci/run-buildbot:518
+generic-debug)
+    export CC=clang-tot
+    export CXX=clang++-tot
----------------
Should be `clang` and `clang++`, like the other jobs?

Also, please move close to the `generic-no-debug)` step.


================
Comment at: libcxx/utils/libcxx/test/config.py:484
         self.cxx.compile_flags += ['-D_LIBCPP_DEBUG=%s' % debug_level]
+        self.config.available_features.add('debug_level_%s' % debug_level)
 
----------------
You can rebase on top of 3d8f2059b95d3e9d6785255949283b258d7ca121.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100866/new/

https://reviews.llvm.org/D100866