[libcxx-commits] [PATCH] D100160: [libcxx] adds `std::input_or_output_iterator` and `std::sentinel_for` to <iterator>

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb marked 4 inline comments as done.
cjdb added inline comments.


================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.iterator/input_or_output_iterator.compile.pass.cpp:64
+
+// <array>
+static_assert(std::input_or_output_iterator<std::array<int, 10>::iterator>);
----------------
ldionne wrote:
> Why do we have those here if we also have the various `iterator_concept_conformance.compile.pass.cpp` tests?
I mustn't have deleted these before pushing :S
Deleted.


================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.sentinel/sentinel_for.compile.pass.cpp:102
+  static_assert(!std::sentinel_for<const_iterator, reverse_iterator>);
+  static_assert(!std::sentinel_for<const_iterator, const_reverse_iterator>);
+
----------------
Mordante wrote:
> Here `iterator` and `const_iterator` are not tested against the full set, like `reverse_iterator` and `const_reverse_iterator`. Can you add them for completeness?
PTAL at the individual tests.


================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.concepts/locale_dependent.compile.pass.cpp:12
+// UNSUPPORTED: gcc-10
+// REQUIRES: locale.en_US.UTF-8
+
----------------
Mordante wrote:
> What's locale dependent with this test?
> If it's locale dependent it should contain a line `// UNSUPPORTED: libcpp-has-no-localization`
File deleted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100160/new/

https://reviews.llvm.org/D100160