[libcxx-commits] [PATCH] D99091: [locale][num_get] Improve Stage 2 of string to float conversion

[Tomas Matheson via Phabricator via libcxx-commits]

tmatheson added a comment.

Ping. @Quuxplusone were there any outstanding issues you wanted me to address?

Also, can anyone suggest what I should do about the ABI issues? The function I've changed (`__num_get<_CharT>::__stage2_float_loop`) doesn't seem like it should be part of the public ABI. After updating the expected names there are still CI failures on MacOS. Should the changes be wrapped with the macros described here? https://libcxx.llvm.org/docs/DesignDocs/ABIVersioning.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99091/new/

https://reviews.llvm.org/D99091