[libcxx-commits] [PATCH] D100881: Implement N3644 "Null Forward Pointers" in _LIBCPP_DEBUG mode.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, Mordante, curdeius, zoecarver.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This functionality is already tested in std/containers/sequences/vector/iterators.pass.cpp.
It was not tested in string.iter/iterators.pass.cpp, so I've also added a test there (and refactored the original to reduce tedium). The added test fails before this patch.

`list` has debug iterators, but it's not random-access (so it has no `<`/`<=` operators to be affected by this patch).
`deque` is random-access, but it doesn't have debug iterators (so it is unaffected by this patch).

This came, obliquely, out of D100866 <https://reviews.llvm.org/D100866>. Fixing this test now means I won't have to mark it XFAILed in debug mode because it no longer fails.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100881

Files:
  libcxx/src/debug.cpp
  libcxx/test/std/strings/basic.string/string.iterators/iterators.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100881.338949.patch
Type: text/x-patch
Size: 3362 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210420/5e02dfd8/attachment.bin>