[libcxx-commits] [PATCH] D100073: [libcxx] adds `std::indirectly_readable` to <iterator>

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added inline comments.


================
Comment at: libcxx/include/__iterator/iterator_traits.h:42
+};
+
 // [iterator.traits]
----------------
cjdb wrote:
> zoecarver wrote:
> > cjdb wrote:
> > > zoecarver wrote:
> > > > Shouldn't these go in `__iterator/concepts.h`?
> > > No, that will create a circular dependency.
> > How so? `iterator_traits.h` should be able to include `concepts.h`.
> `concepts.h` needs to include `iterator_traits.h` because it needs the iterator tag types. I could alternatively put them in their own small header, but //something// needs to be moved around.
So, no one else needs `__dereferenceable` and friends? Fair enough. I'm fine with this in that case. I'd also support moving the tags into their own header, but I don't feel strongly one way or another (we can always move stuff around after the fact). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100073/new/

https://reviews.llvm.org/D100073