[libcxx-commits] [PATCH] D100073: [libcxx] adds `std::indirectly_readable` to <iterator>

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added a comment.

In D100073#2702169 <https://reviews.llvm.org/D100073#2702169>, @zoecarver wrote:

> Actually, I'm still not seeing a test where `value_type = void`. Please add that per Louis comment / http://eel.is/c++draft/iterator.assoc.types#readable.traits-note-1
>
> Edit: I do however see `{shared,unique}_ptr<void>`, so that's good!

I don't think this isn't a property of `std::indirectly_readable`: it's a property of `std::indirectly_readable_traits`. Please check lines 179-87 in indirectly_readable_traits.compile.pass.cpp <https://github.com/llvm/llvm-project/blob/main/libcxx/test/std/iterators/iterator.requirements/iterator.assoc.types/readable.traits/indirectly_readable_traits.compile.pass.cpp#L179> for confirmation.



================
Comment at: libcxx/include/__iterator/iterator_traits.h:42
+};
+
 // [iterator.traits]
----------------
zoecarver wrote:
> Shouldn't these go in `__iterator/concepts.h`?
No, that will create a circular dependency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100073/new/

https://reviews.llvm.org/D100073