[libcxx-commits] [PATCH] D100866: [WIP] Add a buildkite for _LIBCPP_DEBUG=1.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Nice to see another improvement to our build pipeline, thanks for working on it! The general approach looks good to me.



================
Comment at: libcxx/src/debug.cpp:441
     __c_node* cj = j != nullptr ? j->__c_ : nullptr;
-    return ci != nullptr && ci == cj;
+    return ci == cj;  // N3644
 }
----------------
This seems trivial, but I think it should land in a separate commit. (I don't mind to do that after accepting this patch.)
I assume this is what you mean with "Land the fix to support N3644 "Null Forward Iterators" in debug mode." correct?

Just curious how did you discover this?


================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:68
 
-  - label: "MacOS C++20"
-    command: "libcxx/utils/ci/run-buildbot generic-cxx20"
+  - label: "Debug Mode"
+    command: "libcxx/utils/ci/run-buildbot generic-debug"
----------------
I'm not to fond of "Debug mode", it sounds too generic for me. How do you feel about "Debug iterators"?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100866/new/

https://reviews.llvm.org/D100866