[libcxx-commits] [PATCH] D100073: [libcxx] adds `std::indirectly_readable` to <iterator>

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added a comment.

In D100073#2702033 <https://reviews.llvm.org/D100073#2702033>, @cjdb wrote:

> rebases so @zoecarver can continue working
>
> The addition of `indirectly_writable` is accidental (probably a rebase gone wrong) and will be fixed in the next `arc diff`.
> It shouldn't affect @zoecarver's work at all.

In hindsight, I think it might be easier to abandon D100078 <https://reviews.llvm.org/D100078> since it's magically transported into D100073 <https://reviews.llvm.org/D100073>.



================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.readable/indirectly_readable.compile.pass.cpp:57
+
+struct alternative_indirection {
+  using element_type = long;
----------------
zoecarver wrote:
> Might as well put this in the header too, no? I think it makes sense to have all these types live together. 
These types are exclusively for `indirectly_readable`, so I'd prefer to keep them here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100073/new/

https://reviews.llvm.org/D100073