[libcxx-commits] [PATCH] D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D94511#2698917 <https://reviews.llvm.org/D94511#2698917>, @Quuxplusone wrote:

> @Mordante wrote:
>
>> There are still quite some formatting errors, for example `() ,` instead of `(),`, please use the instructions here to format the patch https://llvm.org/docs/Contributing.html#how-to-submit-a-patch
>
> @Mordante: That's intentional; we write `(x , ...)` when we're folding over `operator,`. If clang-format can't tell the difference, that's a bug in clang-format.
> (All: Please do //not// blindly clang-format; that just introduces whitespace errors that someone else will have to fix manually down the road.)

I was mainly concerned since a previous iteration had indention errors. I still prefer to leave the formatting to clang-format and be happy with it. But I know you have a different opinion. But since you asked for this formatting change I'm not objecting. So LGTM, even if it already landed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94511/new/

https://reviews.llvm.org/D94511