[libcxx-commits] [PATCH] D100828: Remove if-else to make branch predictor happy

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.

Also LGTM. To clarify @ldionne's comment: Normally buildkite runs a clang-format check, which is allowed to "soft-fail" (it'll tell you that clang-format disagrees with the patch's style, but it won't break the build, and you'll still end up with a green light from buildkite). In this PR, though, you caught `main` at a bad time: the clang-format check was "hard-failing" <https://buildkite.com/llvm-project/libcxx-ci/builds/2663#5d6ee11d-3431-4a04-ab8d-6a3e3e0acab6> because of a misconfiguration. The misconfiguration was fixed in ff0ada4e1607385be30b2b38885cea2127568e04 <https://reviews.llvm.org/rGff0ada4e1607385be30b2b38885cea2127568e04>. So, if you rebase, then you should see buildkite (either soft-fail or pass) the clang-format check as intended, and then it'll run the rest of the tests. If the rest of the tests are green, then ship it!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100828/new/

https://reviews.llvm.org/D100828