[libcxx-commits] [PATCH] D100789: [libcxx] [test] Convert a couple of LIBCXX-WINDOWS-FIXME into XFAIL: windows-dll for known bugs

Tue Apr 20 02:59:41 PDT 2021

mstorsjo added a comment.

In D100789#2700970 <https://reviews.llvm.org/D100789#2700970>, @curdeius wrote:

> LGTM. IIUC these tests will unexpectedly pass when this bug is fixed in clang, right? And then, we would be able to remove XFAIL annotations. If it's so, then it's good.

Yep, that's correct.

================
Comment at: libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp:11

-// XFAIL: LIBCXX-WINDOWS-FIXME
+// https://bugs.llvm.org/show_bug.cgi?id=41018
+// XFAIL: windows-dll
----------------
curdeius wrote:
> 
Thanks, will apply that change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100789/new/

https://reviews.llvm.org/D100789