[libcxx-commits] [PATCH] D100029: [libcxx][test] Properly construct containers in debug mode tests for map/set
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Apr 19 18:26:22 PDT 2021
Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.
LGTM. As I now understand the current situation: D100029 <https://reviews.llvm.org/D100029> now //does not change anything about `_LIBCPP_ASSERT` nor `test/support/`//.
It's just changing these tests' `main` functions to make sure they operate on non-empty containers so that they don't prematurely hit an assert and exit "successfully failed."
I think we should land this so we can move on to D100595 <https://reviews.llvm.org/D100595>.
@curdeius?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100029/new/
https://reviews.llvm.org/D100029
More information about the libcxx-commits
mailing list