[libcxx-commits] [PATCH] D100789: [libcxx] [test] Convert a couple of LIBCXX-WINDOWS-FIXME into XFAIL: windows-dll for known bugs

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

These are caused due to inconsistencies regarding always inline in
combination with dllimport. A bug report reference is added next to
each XFAIL line.

This depends on D100221 <https://reviews.llvm.org/D100221> for adding the 'windows-dll' feature to check
for.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100789

Files:
  libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
  libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
  libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
  libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp


Index: libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp
===================================================================
--- libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp
+++ libcxx/test/std/localization/locales/locale/locale.operators/compare.pass.cpp
@@ -6,7 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// https://bugs.llvm.org/show_bug.cgi?id=41018
+// XFAIL: windows-dll
 
 // <locale>
 
Index: libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
===================================================================
--- libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
+++ libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/hash.pass.cpp
@@ -6,6 +6,9 @@
 //
 //===----------------------------------------------------------------------===//
 
+// https://bugs.llvm.org/show_bug.cgi?id=41018
+// XFAIL: windows-dll
+
 // <locale>
 
 // template <class charT> class collate;
@@ -14,8 +17,6 @@
 
 //   This test is not portable
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 #include <locale>
 #include <string>
 #include <cassert>
Index: libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
===================================================================
--- libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
+++ libcxx/test/std/localization/locale.categories/category.collate/locale.collate/locale.collate.members/compare.pass.cpp
@@ -6,6 +6,9 @@
 //
 //===----------------------------------------------------------------------===//
 
+// https://bugs.llvm.org/show_bug.cgi?id=41018
+// XFAIL: windows-dll
+
 // <locale>
 
 // template <class charT> class collate;
@@ -13,8 +16,6 @@
 // int compare(const charT* low1, const charT* high1,
 //             const charT* low2, const charT* high2) const;
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 #include <locale>
 #include <cassert>
 
Index: libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
===================================================================
--- libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
+++ libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/hash.pass.cpp
@@ -8,7 +8,8 @@
 
 // REQUIRES: locale.en_US.UTF-8
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// https://bugs.llvm.org/show_bug.cgi?id=41018
+// XFAIL: windows-dll
 
 // <locale>
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100789.338621.patch
Type: text/x-patch
Size: 2794 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210419/ef54b9a9/attachment.bin>