[libcxx-commits] [PATCH] D100686: [libc++][nfc] Move iterator_traits and related into __iterator/iterator_traits.h.

Mon Apr 19 07:27:31 PDT 2021

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM but:

1. Sort includes
2. Make sure you include-what-you-use

Agreed with @Mordante, only add a comment explaining why you add an `#include` when it's not obvious why the `#include` is needed, otherwise those comments become outdated too quickly to be useful.

================
Comment at: libcxx/include/iterator:419-421
 #include <__iterator/incrementable_traits.h>
 #include <__iterator/readable_traits.h>
+#include <__iterator/iterator_traits.h>
----------------
Please sort those includes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100686/new/

https://reviews.llvm.org/D100686