[libcxx-commits] [PATCH] D100736: [libc++] s/_LIBCPP_NO_HAS_CHAR8_T/_LIBCPP_HAS_NO_CHAR8_T/g

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Apr 18 18:51:22 PDT 2021


Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, curdeius, Mordante, kamleshbhalui.
Quuxplusone added a project: libc++.
Herald added a subscriber: arichardson.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This was raised in D94511 <https://reviews.llvm.org/D94511>.
@ldionne, could this renaming cause any issues for users? Do users ever define `_LIBCPP_NO_HAS_CHAR8_T`? and if so, do we care about breaking them (more than we care about long-term consistency of naming)?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100736

Files:
  libcxx/include/__config
  libcxx/include/__locale
  libcxx/include/__string
  libcxx/include/atomic
  libcxx/include/cstddef
  libcxx/include/filesystem
  libcxx/include/iosfwd
  libcxx/include/string
  libcxx/include/string_view
  libcxx/include/utility
  libcxx/include/version
  libcxx/src/locale.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/advance_to.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/begin.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/ctor.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/end.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/types.compile.pass.cpp
  libcxx/test/support/test.support/make_string_header.pass.cpp
  libcxx/utils/generate_feature_test_macro_components.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100736.338408.patch
Type: text/x-patch
Size: 18829 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210419/f41825fa/attachment-0001.bin>


More information about the libcxx-commits mailing list