[libcxx-commits] [PATCH] D100730: [libc++] Simplify debug iterators, and fix a couple of non-explicit constructors.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Apr 18 16:48:08 PDT 2021


Quuxplusone added a comment.

Turns out that my regression test "proving" that `{0,0}` is not a vector::iterator actually may indicate a non-conformance in Clang's overload resolution rules — GCC and MSVC disagree with Clang. So I plan to just remove those two new tests (but not revert the addition of `explicit` to those constructors, since that's obviously a good idea).
Example of disagreement between GCC and Clang: https://godbolt.org/z/cedPxnzz1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100730/new/

https://reviews.llvm.org/D100730



More information about the libcxx-commits mailing list