[libcxx-commits] [PATCH] D100730: [libc++] Simplify debug iterators, and fix a couple of non-explicit constructors.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, krisb.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This is actually three related commits in one:

  commit 11d578daf3e499100b8126e9c8f574f58ebe6f2c (HEAD -> list-debug-mode)
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   Sun Apr 18 15:15:10 2021 -0400
  
      [libc++] __bit_iterator's constructor needs explicit.
      
      Expand the regression test to also catch this one.
  
  commit 34df8a2d303a40ef1e498f9f86d3dd1d7610d3c0
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   Sun Apr 18 14:10:16 2021 -0400
  
      [libc++] __wrap_iter's constructor needs explicit; make it look like __list_iterator.
      
      And add a regression test.
  
  commit 1adf6ac48d2e255ff59e1851fb2f33861464b107
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   Sun Apr 18 14:02:12 2021 -0400
  
      [libc++] Give list::iterator the same constructor in debug and non-debug modes.
      
      Inlining will take care of the codegen; get rid of a lot of #ifs.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100730

Files:
  libcxx/include/__bit_reference
  libcxx/include/iterator
  libcxx/include/list
  libcxx/include/span
  libcxx/include/string
  libcxx/include/vector
  libcxx/test/libcxx/containers/sequences/vector/explicit_iterator_cons.compile.pass.cpp
  libcxx/test/libcxx/strings/basic.string/string.iterators/explicit_iterator_cons.compile.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100730.338389.patch
Type: text/x-patch
Size: 16445 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210418/16980f08/attachment.bin>