[libcxx-commits] [PATCH] D100610: Don't fail the shared_ptr test if libc++ has insufficient debug info.

[David Blaikie via Phabricator via libcxx-commits]

dblaikie added a comment.

Generally makes sense to me - I'd probably lean on this being a bit too narrow (but if it handles the current cases, we can generalize if/when needed), in that it'll be a bit brittle to changes to libc++. Well, I guess if anything's renamed, or moved into the libc++ library it'll require touching the pretty printer anyway.

Ah, I see - so you're looking for the field which is a member of __shared_count - might be good for the comment to have a few more words about what the purpose is there. Connecting the dots between "determine if libc++ itself has debug info" and why this test achieves that result (something like... because __shared_count has virtual functions and has its key function defined in the libc++ library, so the type definition will only be emitted there (if libc++ itself is built with debug info) and without the definition the __shared_owners_ field won't be available)

Any sense of the difference between UNSUPPORTED and IGNORED for things like this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100610/new/

https://reviews.llvm.org/D100610