[libcxx-commits] [PATCH] D98573: [libc++] Remove the special logic for "noexcept iterators" in basic_string

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone updated this revision to Diff 338355.
Quuxplusone added a comment.

The gift that keeps on giving... ASAN finds a memory leak in `basic_string::__init` — apparently `__init` is called from constructors, so if it throws, it is responsible for deallocating the buffer itself. This is now fixed.
https://buildkite.com/llvm-project/libcxx-ci/builds/2613#fc0d2573-8a43-4b02-b142-009a84ef9b06


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98573/new/

https://reviews.llvm.org/D98573

Files:
  libcxx/include/filesystem
  libcxx/include/iterator
  libcxx/include/string
  libcxx/test/libcxx/iterators/trivial_iterators.pass.cpp
  libcxx/test/libcxx/strings/iterators.exceptions.pass.cpp
  libcxx/test/libcxx/strings/iterators.noexcept.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/robust_against_adl.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_append/iterator.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_assign/iterator.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_insert/iter_iter_iter.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_replace/iter_iter_iter_iter.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98573.338355.patch
Type: text/x-patch
Size: 44404 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210418/86c8a393/attachment-0001.bin>