[libcxx-commits] [PATCH] D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

LGTM modulo some minor requests.



================
Comment at: libcxx/utils/ci/run-buildbot:140
+    # Reject patches that introduce non-ASCII characters or hard tabs.
+    ! grep -r '[^ -~]' libcxx/include/
+    # Reject patches that don't update the generated output correctly.
----------------
Can you change this to `grep -rn` to show the line number of the offending line.


================
Comment at: libcxx/utils/ci/run-buildbot:149
+    # Check that no dependency cycles have been introduced.
+    python3 libcxx/utils/graph_header_deps.py >/dev/null
 ;;
----------------
The output now looks like
```
Cycle detected between /home/libcxx-builder/.buildkite-agent/builds/356c9f0d4df7-1/llvm-project/libcxx-ci/libcxx/include/__memory/shared_ptr.h and /home/libcxx-builder/.buildkite-agent/builds/356c9f0d4df7-1/llvm-project/libcxx-ci/libcxx/include/__memory/pointer_traits.h
```
Would it be easy to remove a part of the prefix to make the output easier to read? It would be great if we can omit the part identical to our current working directory.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100703/new/

https://reviews.llvm.org/D100703