[libcxx-commits] [PATCH] D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/utils/ci/run-buildbot:145-146
     ! grep -q '^--- a' ${BUILD_DIR}/generated_output.patch
+    # Check that no dependency cycles have been introduced.
+    python3 libcxx/utils/graph_header_deps.py >/dev/null
 ;;
----------------
> https://buildkite.com/llvm-project/libcxx-ci/builds/2595#c3483aa2-87b6-44fd-870e-4ce28b115ccc shows build errors. I assume these aren't the intended errors. I would like to see how a build failure for this script is intended to look at the CI.

Yikes, that's interesting! `'ascii' codec can't decode byte 0xe2 in position 392` means we're getting some sort of UTF-8 (`e2` is a common onset in UTF-8) somewhere in one of the header files. But I don't see any such thing on my local laptop. I'll investigate by spamming buildkite. Please ignore the next few pokes. :)  Once I diagnose that issue, I'll cause the intended build failure and link you to it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100703/new/

https://reviews.llvm.org/D100703