[libcxx-commits] [PATCH] D100686: [libc++][nfc] Move iterator_traits and related into __iterator/iterator_traits.h.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Apr 17 08:09:40 PDT 2021


Mordante added a comment.

I like these cleanups!



================
Comment at: libcxx/include/__iterator/iterator_traits.h:14
+#include <__config>
+#include <concepts>
+
----------------
Are we expecting `<concepts>` to include `<type_traits>`?


================
Comment at: libcxx/include/iterator:416
 #include <compare>
 #include <concepts>
 #include <cstddef>
----------------
The new header includes `<concepts>`. What's our policy for including this header here too? I would prefer to remove it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100686/new/

https://reviews.llvm.org/D100686



More information about the libcxx-commits mailing list