[libcxx-commits] [PATCH] D100682: [libc++][nfc] Move incrementable_traits and indirectly_readable_traits into separate headers.

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 16 23:05:06 PDT 2021


cjdb added inline comments.


================
Comment at: libcxx/include/__iterator/concepts.h:1
+// -*- C++ -*-
+//===----------------------------------------------------------------------===//
----------------
I made a mistake: putting them in this header will create circular dependencies, since `iterator_traits` needs these exposition-only concepts and `__iterator_traits/concepts.h` will depends on `iterator_traits`. They, along with the //`cpp17-*-iterator`// concepts should either be in `__iterator/iterator_traits.h`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100682/new/

https://reviews.llvm.org/D100682



More information about the libcxx-commits mailing list