[libcxx-commits] [PATCH] D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Apr 16 13:32:48 PDT 2021
ldionne added inline comments.
================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.cust/iterator.cust.move/iter_move.pass.cpp:186
+ static_assert(check_iter_move());
+ assert(check_iter_move());
+
----------------
cjdb wrote:
> zoecarver wrote:
> > No need to call assert here.
> Don't we want to check the run-time value as well?
Yes, I think we do. I'm leaving the `assert` in place.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99873/new/
https://reviews.llvm.org/D99873
More information about the libcxx-commits
mailing list