[libcxx-commits] [PATCH] D100682: [libc++][nfc] Move incrementable_traits and indirectly_readable_traits into separate headers.

Fri Apr 16 13:30:52 PDT 2021

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with fixes applied and CI passing. Thanks!

================
Comment at: libcxx/include/__iterator/incrementable_traits.h:1
+#ifndef _LIBCPP___ITERATOR_INCREMENTABLE_TRAITS_H
+#define _LIBCPP___ITERATOR_INCREMENTABLE_TRAITS_H
----------------
This needs a license. What I generally do is copy-paste an existing header and replace the contents. That makes sure I get the right boilerplate (not that we shouldn't work on reducing that boilerplate if possible, especially the pragma stuff).

================
Comment at: libcxx/include/__iterator/readable_traits.h:16
+
+#if !defined(_LIBCPP_HAS_NO_RANGES)
+
----------------
It would make sense to hoist that out of this file and into `<iterator>`. Same for incrementable traits.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100682/new/

https://reviews.llvm.org/D100682