[libcxx-commits] [PATCH] D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 16 08:30:40 PDT 2021


ldionne added inline comments.


================
Comment at: libcxx/include/concepts:252
+  is_class_v<remove_cvref_t<_Tp>> ||
+  is_union_v<remove_cvref_t<_Tp>> ||
+  is_enum_v<remove_cvref_t<_Tp>>;
----------------
Why are we checking for `union` here? Is it because the spec says `has class or enumeration type`, and a union is technically a class type even though `is_class` returns false for it? @tcanens Do you know what the intent of the spec is in that regard?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99873/new/

https://reviews.llvm.org/D99873



More information about the libcxx-commits mailing list