[libcxx-commits] [PATCH] D99855: [libcxx] makes `iterator_traits` C++20-aware

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/test/std/iterators/iterator.primitives/iterator.traits/cxx20_iterator_traits.compile.pass.cpp:72
+  struct reference {};
+  // TODO
+  value_type*
----------------
TODO?


================
Comment at: libcxx/test/std/iterators/iterator.primitives/iterator.traits/cxx20_iterator_traits.compile.pass.cpp:278
+
+struct LegacyRandomAccess {
+  struct value_type {};
----------------
I think these are a duplication of what's in `test/libcxx/iterators/iterator.requirements/iterator.assoc.types/iterator.traits/iterator_traits_cpp17_iterators.h`. Could you please confirm?


================
Comment at: libcxx/test/std/iterators/iterator.primitives/iterator.traits/empty.fail.cpp:103
     }
-
+#endif
     {
----------------
zoecarver wrote:
> Nit: `// _LIBCPP_STD_VER <= 17 || defined(_LIBCPP_HAS_NO_CONCEPTS)`
This should be `!defined(_LIBCPP_HAS_NO_RANGES)` now (I didn't get around to fixing it up).


================
Comment at: libcxx/test/std/iterators/iterator.primitives/iterator.traits/legacy_iterator_wrappers.h:1
+//===----------------------------------------------------------------------===//
+//
----------------
Do we still need this file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99855/new/

https://reviews.llvm.org/D99855