[libcxx-commits] [PATCH] D100592: [libcxx][test] Split off debug mode tests

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added inline comments.


================
Comment at: libcxx/test/libcxx/containers/sequences/vector/db_back.pass.cpp:32-33
+  c.clear();
+  assert(c.back() == 0);
+  assert(false);
+
----------------
IIUC, this can/should be simply
```
(void)c.back();  // expect this to exit
assert(false);
```
But as long as you fix it in D100595, it's no problem to leave it wonky in this commit.


================
Comment at: libcxx/test/libcxx/strings/basic.string/string.iterators/db_iterators_9.pass.cpp:14
 // UNSUPPORTED: libcxx-no-debug-mode
+// UNSUPPORTED: c++03
 
----------------
Why is this test unsupported in C++03? Actually, what on earth is the point of this test?
I'm fine shipping this commit as-is, as long as we get to the bottom of it in D100595.
But I'd be happier with just `git rm`'ing this new file, because (unless I'm missing something) it's identical to db_iterators_2.pass.cpp except for the unneeded `UNSUPPORTED` line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100592/new/

https://reviews.llvm.org/D100592