[libcxx-commits] [PATCH] D100595: [libcxx][test] Attempt to make debug mode tests more bulletproof

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 15 14:41:28 PDT 2021


Quuxplusone added inline comments.


================
Comment at: libcxx/test/libcxx/containers/sequences/list/list.ops/db_splice_pos_list_iter_iter.pass.cpp:17
+
+// FIXME: it doesn't seem like the right assert is caught here.
+#include "debug_macros.h"
----------------
ldionne wrote:
> Any chance we can fix the issue in this patch or in a patch *before* we land this one?
IMHO yes. It seems to be a very straightforwardly missing assertion, circa line 2099 of <list>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100595/new/

https://reviews.llvm.org/D100595



More information about the libcxx-commits mailing list