[libcxx-commits] [PATCH] D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added inline comments.


================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.assoc.types/readable.traits/indirectly_readable_traits.compile.pass.cpp:22
+#include <vector>
+
+// `value_type` and `element_type` member aliases aren't actually used to declare anytihng, so GCC
----------------
curdeius wrote:
> zoecarver wrote:
> > cjdb wrote:
> > > zoecarver wrote:
> > > > Forgot one thing: can you please include `test_macros.h` here and in all your other patches/test files? 
> > > Why is that necessary?
> > I thought we had a discussion in discord that we were always going to include this in all passing test files. That way we can easily grep and verify that every file has it. (I made a commit a while back to update all files that didn't include it.)
> > 
> > The main reason it's necessary is to prevent people from accidentally using `TEST_STD_VER` when it's not defined. There have been several instances where that has disabled test code without any warning/error. 
> I've recently committed addition of -Wundef that should prevent this sort of errors so including this header everywhere is not really necessary IMO.
Okay, in that case I don't feel strongly as to whether you add it or not. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99461/new/

https://reviews.llvm.org/D99461