[libcxx-commits] [PATCH] D100587: [libc++][ranges] iterator.concept.sizedsentinel: sized_sentinel_for and disable_sized_sentinel_for.

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.sentinel/sized_sentinel_for.compile.pass.cpp:155-162
+// <filesystem>
+#ifndef _LIBCPP_HAS_NO_FILESYSTEM_LIBRARY
+static_assert(!std::sized_sentinel_for<std::filesystem::directory_iterator,
+                                       std::filesystem::directory_iterator>);
+static_assert(
+    !std::sized_sentinel_for<std::filesystem::recursive_directory_iterator,
+                             std::filesystem::recursive_directory_iterator>);
----------------
Quuxplusone wrote:
> I don't think this test should depend on <filesystem>. (As below, all you're testing here is that you can't subtract `directory_iterator`s, and we knew that already.)
> and we knew that already

Which existing tests confirm this isn't possible?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100587/new/

https://reviews.llvm.org/D100587