[libcxx-commits] [PATCH] D90999: [libc++] Implements ranges::enable_borrowed_range

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 15 12:42:59 PDT 2021


ldionne added a comment.

In D90999#2692573 <https://reviews.llvm.org/D90999#2692573>, @ldionne wrote:

> AFAICT, the only things are:
>
> 1. Rename the header to `__ranges/borrowed_range.h` or similar, with the intent of having both the concept and the helper in it.

Forget about this. I just spoke to Arthur and he explained that the very purpose of splitting the customization point into its own header was to avoid dragging all of `<ranges>` in the other headers. That makes total sense, I had missed that. So then I think the name of the header should just reflect what's in it, i.e. `enable_borrowed_range.h` or the like.

Still LGTM with that naming sorted out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90999/new/

https://reviews.llvm.org/D90999



More information about the libcxx-commits mailing list