[libcxx-commits] [PATCH] D98573: [libc++] Remove most of the special logic for "noexcept iterators" in basic_string

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone updated this revision to Diff 337820.
Quuxplusone edited the summary of this revision.
Quuxplusone added a comment.

Rebase. Add a code comment and refactor a condition. Remove the simple but strictly unnecessary special case for "`insert` at end of string." Completely rewrite the commit message again. Drive-by ADL-proofing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98573/new/

https://reviews.llvm.org/D98573

Files:
  libcxx/include/filesystem
  libcxx/include/string
  libcxx/test/libcxx/strings/iterators.exceptions.pass.cpp
  libcxx/test/libcxx/strings/iterators.noexcept.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_append/robust_against_adl.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_append/strong_guarantee.pass.cpp
  libcxx/test/std/strings/basic.string/string.modifiers/string_insert/strong_guarantee.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98573.337820.patch
Type: text/x-patch
Size: 27972 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210415/4159cb2e/attachment-0001.bin>