[libcxx-commits] [PATCH] D100477: [libc++] Remove test suite workarounds on Apple with old Clangs

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Apr 15 10:01:10 PDT 2021


ldionne added a comment.

CI tests passed but failed to update in Phab. Shippping now.

In D100477#2689486 <https://reviews.llvm.org/D100477#2689486>, @Quuxplusone wrote:

> LGTM!
> Bonus tech-debt points if you want to make a followup NFC commit to consistently use `ASSERT_SAME_TYPE` and, like, `const wchar_t *cws` instead of manual casting everywhere.

Yeah, I'll do that in a follow-up NFC. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100477/new/

https://reviews.llvm.org/D100477



More information about the libcxx-commits mailing list