[libcxx-commits] [PATCH] D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added inline comments.


================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.assoc.types/readable.traits/indirectly_readable_traits.compile.pass.cpp:186
+
+  return result;
+}
----------------
cjdb wrote:
> zoecarver wrote:
> > What about `&& result == false;` because this should never be true AFAICT. 
> I'm a bit confused. `result && result == false` is a contradiction?
It's a moot point now that you're returning `result`, but I was saying, you could verify that `check_has_value_type<ref_element> == result && result == false`. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99461/new/

https://reviews.llvm.org/D99461