[libcxx-commits] [PATCH] D100410: [libc++] Disentangle std::pointer_safety

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 13 13:47:37 PDT 2021


ldionne created this revision.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This patch gets rid of technical debt around std::pointer_safety which,
I claim, is entirely unnecessary. I don't think anybody has used
std::pointer_safety in actual code because we do not implement the
underlying garbage collection support. As such, I think it's entirely
fine to get rid of complex workarounds whose goals were to avoid breaking
the ABI back in 2017.

I'm putting this up both to get reviews and to discuss this proposal for
a breaking change. I think we should be comfortable with making these
tiny breaks if we are confident they won't hurt anyone, which I'm fairly
confident is the case here.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100410

Files:
  libcxx/docs/ReleaseNotes.rst
  libcxx/include/__config
  libcxx/include/__memory/pointer_safety.h
  libcxx/include/memory
  libcxx/lib/abi/x86_64-apple-darwin.libcxxabi.v1.stable.exceptions.no_new_in_libcxx.abilist
  libcxx/lib/abi/x86_64-unknown-linux-gnu.libcxxabi.v1.stable.exceptions.no_new_in_libcxx.abilist
  libcxx/src/memory.cpp
  libcxx/test/libcxx/utilities/memory/util.dynamic.safety/get_pointer_safety_cxx03.pass.cpp
  libcxx/test/libcxx/utilities/memory/util.dynamic.safety/get_pointer_safety_new_abi.pass.cpp
  libcxx/test/std/utilities/memory/util.dynamic.safety/get_pointer_safety.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100410.337253.patch
Type: text/x-patch
Size: 10977 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210413/7d41a766/attachment-0001.bin>


More information about the libcxx-commits mailing list