[libcxx-commits] [PATCH] D90999: [libc++] Implements ranges::enable_borrowed_range

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/module.modulemap:414
+    header "ranges"
+    export __ranges_enable_helpers
+    export *
----------------
zoecarver wrote:
> Mordante wrote:
> > Quuxplusone wrote:
> > > We don't do this line for any other header, e.g. `__functional_base`, so I don't think it should be necessary here.
> > I looked at `__string`, but that seems to be the exception. So I'll remove this one.
> Hmm, my vote would be to export it as well. But I don't feel strongly. Do we have a policy on this @ldionne @EricWF?
FYI @zoecarver, this comment has moved since I made it. We shouldn't export `__ranges_enable_borrowed_range` or whatever we're calling it; but of course we should export `ranges`! :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90999/new/

https://reviews.llvm.org/D90999