[libcxx-commits] [PATCH] D100393: [libc++][docs] Add status docs for ranges.

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb accepted this revision.
cjdb added a comment.

LGTM. You don't necessarily need to apply my comments; they're for tracking so that I remember to mark as WIP or complete before making a final merge.



================
Comment at: libcxx/docs/OneRangesProposalStatus.csv:6
+[memory.syn],Add specializations for uninitialized_* and destroy_*. ,"[concepts], [readable.traits]: iter_value_t",,
+[readable.traits]: readable_traits,readable_traits only. ,[concepts],,
+[iterator.traits],Mainly updates to iterator_traits.,"[readable.traits]: readable_traits, [concepts]",,
----------------
D99461


================
Comment at: libcxx/docs/OneRangesProposalStatus.csv:7
+[readable.traits]: readable_traits,readable_traits only. ,[concepts],,
+[iterator.traits],Mainly updates to iterator_traits.,"[readable.traits]: readable_traits, [concepts]",,
+[readable.traits]: iter_value_t,Finish implementing readable.traits.,"[readable.traits]: readable_traits, [concepts], [iterator.traits]",,
----------------
D99854 and D99855


================
Comment at: libcxx/docs/OneRangesProposalStatus.csv:8
+[iterator.traits],Mainly updates to iterator_traits.,"[readable.traits]: readable_traits, [concepts]",,
+[readable.traits]: iter_value_t,Finish implementing readable.traits.,"[readable.traits]: readable_traits, [concepts], [iterator.traits]",,
+[specialized.algorithms],NOT FINISHED,NOT FINISHED,,
----------------
D99863


================
Comment at: libcxx/docs/OneRangesProposalStatus.csv:12
+[views.span],Same as [strings],[iterator.concepts],,
+[incrementable.traits],,[concepts],,
+[iterator.cust.move],Implement iter_move.,,,
----------------
D99141 and D99863


================
Comment at: libcxx/docs/OneRangesProposalStatus.csv:13
+[incrementable.traits],,[concepts],,
+[iterator.cust.move],Implement iter_move.,,,
+[iterator.cust.swap],Implement iter_swap.,"[concepts], [readable.traits]: iter_value_t",,
----------------
D99873


================
Comment at: libcxx/docs/OneRangesProposalStatus.csv:15
+[iterator.cust.swap],Implement iter_swap.,"[concepts], [readable.traits]: iter_value_t",,
+[iterator.concepts],"Readable, Writable, WeaklyIncrementable, Incremental, Iterator, Sentinel, SizedSentinel, InputIterator, OutputIterator, ForwardIterator, BidirectionalIterator, RandomAccessIterator, and ContiguousIterator.","[concepts], [readable.traits]: iter_value_t, [iterator.traits]",,
+[indirectcallable.indirectinvocable],"IndirectUnaryInvocable, IndirectRegularUnaryInvocable, IndirectUnaryPredicate, IndirectRelation, and IndirectStrictWeakOrder","[concepts], [readable.traits]: iter_value_t, [iterator.traits]",,
----------------
* `indirectly_readable`: D100073
* `indirectly_wriatable`: D100078
* `weakly_incrementable`, `incrementable`: D100080
* `input_or_output_iterator`, `sentinel_for`: D100160
* `input_iterator`: D100271
* `forward_iterator`: D100275
* `bidirectional_iterator`: D100278


================
Comment at: libcxx/docs/OneRangesProposalStatus.csv:34
+[ranges.syn]: pt. 1,All the stuff not specified elsewhere. ,"[range.access], [iterator.concepts], [range.all], [range.subrange], unreachable, [range.empty]",,
+[ranges.syn]: pt. 2,"iterator_t, sentinel_t, and safe_iterator_t",[range.access],,
+[range.access],"ranges::begin, end, cbegin, cend, rbegin, rend, crbegin, and crend",[iterator.concepts],,
----------------
D100255 and D100269


================
Comment at: libcxx/docs/OneRangesProposalStatus.csv:35
+[ranges.syn]: pt. 2,"iterator_t, sentinel_t, and safe_iterator_t",[range.access],,
+[range.access],"ranges::begin, end, cbegin, cend, rbegin, rend, crbegin, and crend",[iterator.concepts],,
+[ranges.primitives],"size, empty, data, and cdata",[iterator.concepts],,
----------------
`ranges::begin`, `ranges::end`, `ranges::cbegin`, `ranges::cend`: D100255


================
Comment at: libcxx/docs/OneRangesProposalStatus.csv:40
+[range.view],View and enable_view,[range.range],,
+[range.refinements],"OutputRange, InputRange, ForwardRange, BidirectionalRange, RandomAccessRange, ContiguousRange, CommonRange, ViewableRange","[ranges.syn]: pt. 2, [range.range]",,
+[view.interface],[range.utility.helpers] and view_interface,"[ranges.syn]: pt. 2, [range.view], [range.iterator.opearations.prev], [range.refinements]",,
----------------
* `input_range`: D100271
* `forward_range`: D100275
* `bidirectional_range`: D100278


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100393/new/

https://reviews.llvm.org/D100393