[libcxx-commits] [PATCH] D99141: [libcxx] adds `std::incrementable_traits` to <iterator>

[Nico Weber via Phabricator via libcxx-commits]

thakis added inline comments.


================
Comment at: libcxx/include/iterator:446
+template<class _Tp>
+requires is_object_v<_Tp>
+struct incrementable_traits<_Tp*> {
----------------
thakis wrote:
> This breaks using this header with `-std=c++14` apparently: http://45.33.8.238/linux/43983/step_4.txt
> 
> Looks like _LIBCPP_HAS_NO_RANGES is supposed to be defined in that case, but maybe it doesn't work right?
Oh wait, this might be a bot config problem. Please ignore for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99141/new/

https://reviews.llvm.org/D99141