[libcxx-commits] [PATCH] D90999: [libc++] Implements ranges::enable_borrowed_range

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 12 22:08:13 PDT 2021


cjdb added inline comments.


================
Comment at: libcxx/include/__ranges_enable_helpers:1
+// -*- C++ -*-
+//===----------------------- __ranges_enable_helpers ----------------------===//
----------------
Please change the path to `__ranges/enable_helpers.h` and move the synopsis to `<ranges>`.


================
Comment at: libcxx/include/__ranges_enable_helpers:38
+
+#if _LIBCPP_STD_VER > 17
+
----------------
We've got a `_LIBCPP_HAS_NO_RANGES` macro now that guards on C++20 now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90999/new/

https://reviews.llvm.org/D90999



More information about the libcxx-commits mailing list