[libcxx-commits] [PATCH] D100342: [libcxx] removes operator!= and globally guards against no spaceship operator

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.

This seems like a step in the right direction. Would you be interested in jumping all the way to the full C++20-mandated hidden-friend implementation in one fell swoop? Or is that already on your roadmap?

cppreference says:

> These functions are not visible to ordinary unqualified or qualified lookup, and can only be found by argument-dependent lookup when std::partial_ordering [or whatever] is an associated class of the arguments.

In other words, they should be defined inline, as hidden friends.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100342/new/

https://reviews.llvm.org/D100342