[libcxx-commits] [PATCH] D96523: [libc++] Rewrite the tuple constructors to be strictly Standards conforming

Mon Apr 12 14:49:01 PDT 2021

ldionne marked an inline comment as done.
ldionne added a comment.

In D96523#2674422 <https://reviews.llvm.org/D96523#2674422>, @ldionne wrote:

> In D96523#2674393 <https://reviews.llvm.org/D96523#2674393>, @EricWF wrote:
>
>> There's another bug with SFINAE depth increases that's blowing up at Google.
>> I suspect we can get that back.
>
> Can you post a reproducer? I'll be happy to fix it.

I'll commit this on Wednesday unless I have more information. I don't want to break your internal users, but I'd like to get moving with this patch since it has good chances of being difficult to rebase, so keeping it around for a while is quite risky.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96523/new/

https://reviews.llvm.org/D96523