[libcxx-commits] [PATCH] D100311: [libc++] Test nodiscard attributes of node-handle::empty().

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 12 12:40:31 PDT 2021

Previous message: [libcxx-commits] [PATCH] D100311: [libc++] Test nodiscard attributes of node-handle::empty().
Next message: [libcxx-commits] [PATCH] D100311: [libc++] Test nodiscard attributes of node-handle::empty().
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Quuxplusone added a comment.

FWIW, LGTM at this point except that I still think I'd prefer to see this tested in test/libcxx/diagnostics/nodiscard_extensions.verify.cpp.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100311/new/

https://reviews.llvm.org/D100311

Previous message: [libcxx-commits] [PATCH] D100311: [libc++] Test nodiscard attributes of node-handle::empty().
Next message: [libcxx-commits] [PATCH] D100311: [libc++] Test nodiscard attributes of node-handle::empty().
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the libcxx-commits mailing list