[libcxx-commits] [PATCH] D90202: [libunwind] Fix linker flag handling in the tests.

[Daniel Kiss via Phabricator via libcxx-commits]

danielkiss added inline comments.


================
Comment at: libunwind/test/libunwind/test/config.py:47
+        # Make symbols available in the tests.
+        if 'linux' in self.config.target_triple:
+            self.cxx.link_flags += ['-Wl,--export-dynamic']
----------------
arichardson wrote:
> This also works on most other operating systems that use ld.lld/ld.bfd (e.g. FreeBSD). Maybe it should be `'darwin' not in  self.config.target_triple`?
Make sense to me, hopefully we have enough bots to tests all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90202/new/

https://reviews.llvm.org/D90202