[libcxx-commits] [PATCH] D100216: [libc++] Split a few things out of <memory>

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 12 08:45:06 PDT 2021


ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/include/__memory/allocator.h:11
+#ifndef _LIBCPP___MEMORY_ALLOCATOR_H
+#define _LIBCPP___MEMORY_ALLOCATOR_H
+
----------------
Mordante wrote:
> `<__string>` contains a duplicate of the synopsis of `char_traits`. These new headers don't have a synopsis. Is that intended or an oversight?
I asked on Discord whether we wanted to keep the synopsis in the public header or split it up in the sub-headers, and we agreed to put the synopsis only in the public header. So I'll remove the synopsis from `__string` in a separate commit for consistency, thanks for the observation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100216/new/

https://reviews.llvm.org/D100216



More information about the libcxx-commits mailing list