[libcxx-commits] [PATCH] D100216: [libc++] Split a few things out of <memory>

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked 2 inline comments as done.
ldionne added a comment.

In D100216#2680460 <https://reviews.llvm.org/D100216#2680460>, @curdeius wrote:

> LGTM. I prefer having clearly cut headers. IMO it is better to have more than not enough. That's of course subjective.

It's "subjective", but then anything related to readability is subjective. I still think the benefits of such a simple change will be overwhelming in the long run -- I'm already starting to see a lot of structure in the library that I didn't see before, yet I've been working on it full time for 3 years.

> BTW. Should I understand that we settled on __memory/* naming scheme?

For now it does the job. I'm not entirely satisfied, for example `__memory/compressed_pair.h` isn't great since `__compressed_pair` isn't strongly tied to `<memory>`. I think better might be `__detail/compressed_pair.h` for things that are not clearly tied to a specific public header. But it'll be easy to change that in the future if we want, and `git` handles renames pretty well, so there shouldn't be any churn generated from changing in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100216/new/

https://reviews.llvm.org/D100216