[libcxx-commits] [PATCH] D79888: libc++: move checks for newlib to actually work

Thu Apr 8 13:05:58 PDT 2021

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

LGTM with nitpick. Once updated, do you need someone to commit this for you? If so, please provide `Author Name <email at domain>` for attribution. Thanks!

================
Comment at: libcxx/include/fstream:201

+#if !defined(_LIBCPP_HAS_NO_OFF_T_FUNCTIONS)
+#  if defined(_LIBCPP_MSVCRT) || defined(_NEWLIB_VERSION)
----------------
You can remove this level of `#if`, we never expect users to define it, and I'd rather not give the impression that we allow users to.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79888/new/

https://reviews.llvm.org/D79888